Messages in this thread | | | Date | Thu, 05 Jan 2006 09:17:15 -0500 | From | Ben Collins <> | Subject | Re: [PATCH 12/15] via-pmu: Wrap some uses of sleep_in_progress with proper ifdef's |
| |
On Thu, 2006-01-05 at 03:34 +0800, Kristian Mueller wrote: > Hi Ben > > On Mi, 2006-01-04 at 17:01 -0500, Ben Collins wrote: > > Basically completes what's already in the rest of the driver. > > sleep_in_progress is only defined for pm+ppc32. > > > > Signed-off-by: Ben Collins <bcollins@ubuntu.com> > > We've already found a different solution to this in the Linuxppc-dev > list. > > See: > http://patchwork.ozlabs.org/linuxppc/patch?id=3737
That patch makes no sense. It just moves the variable out of the ifdef, but if CONFIG_PM or CONFIG_PPC32 is not enabled, then the variable never gets modified, and so is always 0. Why not just wrap all the code that uses it (like my patch did)?
-- Ben Collins <ben.collins@ubuntu.com> Developer Ubuntu Linux
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |