Messages in this thread Patch in this message | | | Subject | [PATCH] sysfs: handle failures in sysfs_make_dirent | Date | Wed, 4 Jan 2006 16:49:31 -0800 | From | Greg KH <> |
| |
[PATCH] sysfs: handle failures in sysfs_make_dirent
I noticed that if sysfs_make_dirent fails to allocate the sd, then a null will be passed to sysfs_put.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- commit e80a5dea8e056d8f398be1900d61c581d379f02f tree 97d6e0d1c669987c54961bec49347b3717e55d52 parent 8218ef80932aa7e5e3d20c929a640c8d82133a9a author Steven Rostedt <rostedt@goodmis.org> Wed, 23 Nov 2005 09:15:44 -0500 committer Greg Kroah-Hartman <gregkh@suse.de> Wed, 04 Jan 2006 16:18:09 -0800
fs/sysfs/dir.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c index 59734ba..d367803 100644 --- a/fs/sysfs/dir.c +++ b/fs/sysfs/dir.c @@ -112,7 +112,11 @@ static int create_dir(struct kobject * k } } if (error && (error != -EEXIST)) { - sysfs_put((*d)->d_fsdata); + struct sysfs_dirent *sd = (*d)->d_fsdata; + if (sd) { + list_del_init(&sd->s_sibling); + sysfs_put(sd); + } d_drop(*d); } dput(*d); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |