Messages in this thread Patch in this message | | | Date | Wed, 4 Jan 2006 18:10:45 +0100 | From | Jesper Juhl <> | Subject | Re: [-mm patch] i386: enable 4k stacks by default |
| |
On 1/4/06, Adrian Bunk <bunk@stusta.de> wrote: > On Wed, Jan 04, 2006 at 05:49:25PM +0100, Jesper Juhl wrote: > > To get maximum testing making 4KSTACKS default Y and removing the "if > > DEBUG_KERNEL" conditional just seems to me to be the obvious choice... > > With my version, we are getting the bigger testing coverage - and > getting a big testing coverage in -mm is what we need if we want to know > whether we have really already fixed all stack problems or whether > there are any left. > Ok, I guess I didn't make myself as clear as I thought. What I meant was that if 4K stacks are always enabled by default, then you'll get more testing than if only people who enable DEBUG_KERNEL are able to turn it on.
So I guess what I'm really aiming at is to either move the option up a level - that is, remove its dependency on CONFIG_DEBUG_KERNEL, or turn the option on its head and make it an option to enable 8K stacks instead and make that option then default to N (I like the first aproach better though).
Something like this :
--- linux-2.6.15-orig/arch/i386/Kconfig.debug 2006-01-03 04:21:10.000000000 +0100 +++ linux-2.6.15/arch/i386/Kconfig.debug 2006-01-04 19:08:43.000000000 +0100 @@ -44,7 +44,7 @@
config 4KSTACKS bool "Use 4Kb for kernel stacks instead of 8Kb" - depends on DEBUG_KERNEL + default y help If you say Y here the kernel will use a 4Kb stacksize for the kernel stack attached to each process/thread. This facilitates -- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |