Messages in this thread | | | Date | Wed, 1 Feb 2006 03:22:33 +0300 | From | Alexey Dobriyan <> | Subject | Re: Liyitec PS/2 touch panel driver [PATCH] |
| |
On Tue, Jan 31, 2006 at 03:59:20PM -0700, Shaun Jackman wrote: > I've written an input driver for the Liyitec PS/2 touch panel. The > patch follows. As this is my first input driver, I'd appreciate any > feedback.
> 2006-01-31 Shaun Jackman <sjackman@gmail.com> > > * drivers/input/touchscreen/Kconfig (TOUCHSCREEN_LIYITEC): New item. > * drivers/input/touchscreen/Makefile: Add liyitec driver. > * drivers/input/touchscreen/liyitec.c: New file. > * include/linux/serio.h (SERIO_LIYITEC): New constant.
This is not ChangeLog style Linux is using.
> +static void liyitec_disconnect(struct serio *serio) > +{ > + struct liyitec *liyitec = serio_get_drvdata(serio); > + > + input_get_device(liyitec->dev);
What do you want to do with return value?
> + input_unregister_device(liyitec->dev); > + serio_close(serio); > + serio_set_drvdata(serio, NULL); > + input_put_device(liyitec->dev); > + kfree(liyitec); > +}
> +static void __exit liyitec_exit(void) > +{ > + printk(KERN_INFO "liyitec: %s\n", __func__);
I suggest to drop this line.
> + serio_unregister_driver(&liyitec_drv); > +}
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |