Messages in this thread | | | Date | Mon, 30 Jan 2006 22:49:08 +0100 | From | Sam Ravnborg <> | Subject | Re: [PATCH] consolidate command line escaping |
| |
On Mon, Jan 30, 2006 at 10:04:27AM +0100, Jan Beulich wrote: > From: Jan Beulich <jbeulich@novell.com> > > While the recent change to also escape # symbols when storing C-file > compilation command lines was helpful, it should be in effect for all > command lines, as much as the dollar escaping should be in effect for > C-source compilation commands. Additionally, for better readability and > maintenance, consolidating all the escaping (single quotes, dollars, > and now sharps) was also desirable.
Very nice paths - thanks! I have applied it locally and will commit if it when testing a bit more.
> -cmd = @$(if $($(quiet)cmd_$(1)),\ > - echo ' $(call escsq,$($(quiet)cmd_$(1)))' &&) $(cmd_$(1)) > +cmd = @$(echo-cmd) $(cmd_$(1)) Here you replace echo 'xxx' && cmd with echo 'xxx'; cmd
Since we assume echo will always succeed I see no difference in behaviour, but I recall the '&&' was there for some specific reason. Just wondering why it is so - I see no problems with it.
Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |