Messages in this thread | | | Date | Mon, 30 Jan 2006 10:43:02 -0800 | From | Greg KH <> | Subject | Re: [PATCH 1/5] pid: Implement task references. |
| |
On Mon, Jan 30, 2006 at 06:19:35AM +0100, Eric Dumazet wrote: > Example of improvement in kref_put() : > > [PATCH] kref : Avoid an atomic operation in kref_put() when the last > reference is dropped. On most platforms, atomic_read() is a plan read of > the counter and involves no atomic at all.
No, we wat to decrement and test at the same time, to protect against any race where someone is incrementing right when we are dropping the last reference.
So, thanks, but I'm not going to apply this.
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |