[lkml]   [2006]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
On Mon, Jan 23, Kirill Korotaev wrote:

> Jan, I still have not heard a single comment about what's wrong with
> it... I would really appreciate if you provide me one.

Sorry for the delay. I had to fix a totally bogus patch (mine ;).

The problem with your patch is that it hides too early mntput's. Think about
following situation:

mntput(path->mnt); // too early mntput()
Assuming that in-between this sequence someone unmounts the file system, your
patch will wait for this dput() to finish before it proceeds with unmounting
the file system. I think this isn't what we want.


Jan Blunck
SuSE LINUX AG - A Novell company
Maxfeldstr. 5 +49-911-74053-608
D-90409 Nürnberg
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2006-01-30 12:57    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean