Messages in this thread | | | Date | Tue, 3 Jan 2006 11:35:33 -0800 | From | Pete Zaitcev <> | Subject | Re: usb: replace __setup("nousb") with __module_param_call |
| |
On Tue, 3 Jan 2006 09:46:26 -0500, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> > But even if it does, my patch saved reading, so I think it should be > > applied as well. > > What you mean by "saved reading"?
The diffstat was almost all dashes: 13 deletions, 1 addition.
> Btw, do we really need to export "nousb" in sysfs?
Nobody would die if we didn't, but there's nothing wrong with the idea in general. At least you'd know that the parameter was actually parsed. I wish usb-handoff was exported similarly, because there's absolutely no way to tell if it worked or was quietly ignored. And I abhor printks in normal or success cases, so I do not want such indication.
-- Pete - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |