Messages in this thread Patch in this message | | | Date | Sun, 29 Jan 2006 16:25:24 -0800 | From | Andrew Morton <> | Subject | Re: 2.6.16-rc1-mm4 |
| |
Adrian Bunk <bunk@stusta.de> wrote: > > n Sun, Jan 29, 2006 at 02:45:33PM -0800, Andrew Morton wrote: > >... > > Changes since 2.6.16-rc1-mm3: > >... > > +i386-add-a-temporary-to-make-put_user-more-type-safe.patch > > > > x86 fixes/features > >... > > This patch generates so many "ISO C90 forbids mixed declarations and code" > warnings that I start to consider Andrew's rejection of my "mark > virt_to_bus/bus_to_virt as __deprecated on i386" patch due to the > warnings it generates a personal insult...
Bah, that's what you get for using a slow compiler.
--- devel/include/asm-i386/uaccess.h~i386-add-a-temporary-to-make-put_user-more-type-safe-fix 2006-01-29 16:24:24.000000000 -0800 +++ devel-akpm/include/asm-i386/uaccess.h 2006-01-29 16:24:24.000000000 -0800 @@ -197,8 +197,9 @@ extern void __put_user_8(void); #define put_user(x,ptr) \ ({ int __ret_pu; \ + __typeof__(*(ptr)) __pu_val; \ __chk_user_ptr(ptr); \ - __typeof__(*(ptr)) __pu_val = x; \ + __pu_val = x; \ switch(sizeof(*(ptr))) { \ case 1: __put_user_1(__pu_val, ptr); break; \ case 2: __put_user_2(__pu_val, ptr); break; \ _ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |