lkml.org 
[lkml]   [2006]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ 00/23] [Suspend2] Freezer Upgrade Patches
Hi!

> This set of patches represents the freezer upgrade patches from Suspend2.
>
> The key features of this changeset are:
>
> - Use of Christoph Lameter's todo list notifiers, which help with SMP
> cleanness.
> - Splitting the freezing of kernel and userspace processes. Freezing
> currently suffers from a race because userspace processes can be
> submitting work for kernel threads, thereby stopping them from
> responding to freeze messages in a timely manner. The freezer can
> thus give up when it doesn't really need to. (This is not normally
> a problem only because load is not usually high).

Exactly. 6 seconds should be enough for signal to be delivered.

> - The use of bdev freezing to ensure filesystems are properly frozen,
> thereby increasing the integrity of on-disk data in the case where
> a resume doesn't occur. This is also helpful in the case of Suspend2,
> where we don't atomically copy all memory, instead writing LRU pages
> separately.

We have talked about this before... we alredy have sync there, and
that's enough. Your patch only makes code more complex for no gain.

Pavel
--
Thanks, Sharp!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-01-26 12:57    [W:0.165 / U:5.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site