![]() | ||||||||||
Messages in this thread |
Hi Matthew, On 1/25/06, Matthew Dobson <colpatch@us.ibm.com> wrote: > +extern void *__kmalloc(size_t, gfp_t, mempool_t *); If you really need to do this, please ntoe that you're adding an extra parameter push for the nominal case where mempool is not required. The compiler is unable to optimize it away. It's better that you create a new entry point for the mempool case in mm/slab.c rather than overloading __kmalloc() et al. See the following patch that does that sort of thing: http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc1/2.6.16-rc1-mm3/broken-out/slab-fix-kzalloc-and-kstrdup-caller-report-for-config_debug_slab.patch Now as for the rest of the patch, are you sure you want to reserve whole pages for each critical allocation that cannot be satisfied by the slab allocator? Wouldn't it be better to use something like the slob allocator to allocate from the mempool pages? That way you wouldn't have to make the slab allocator mempool aware at all, simply make your kmalloc_mempool first try the slab allocator and if it returns NULL, go for the critical pool. All this in preferably separate file so you don't make mm/slab.c any more complex than it is now. Pekka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | |||||||||
| Last update: 2006-01-26 07:43 [from the cache] ©2003-2008 | ||||||||||