lkml.org 
[lkml]   [2006]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [parisc-linux] Re: [PATCH 3/6] C-language equivalents of include/asm-*/bitops.h
    On Thu, Jan 26, 2006 at 08:55:41AM +0000, Russell King wrote:
    > Unfortunately that's not correct. You do not appear to have checked
    > the compiler output like I did - this code does _not_ generate
    > constant shifts.

    Russell,
    By "written stupidly", I thought Richard meant they could have
    used constants instead of "s". e.g.:
    if (word << 16 == 0) { b += 16; word >>= 16); }
    if (word << 24 == 0) { b += 8; word >>= 8); }
    if (word << 28 == 0) { b += 4; word >>= 4); }

    But I prefer what Edgar Toernig suggested.

    grant
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-01-26 17:11    [W:0.021 / U:30.988 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site