Messages in this thread | | | Date | Wed, 25 Jan 2006 18:20:14 +0100 | From | Jens Axboe <> | Subject | Re: CD writing in future Linux (stirring up a hornets' nest) (was: Rationale for RLIMIT_MEMLOCK?) |
| |
On Wed, Jan 25 2006, Joerg Schilling wrote: > Jan Engelhardt <jengelh@linux01.gwdg.de> wrote: > > > > > >> And if you check the amount of completely unneeded code Linux currently has > > >> just to implement e.g. SG_IO in /dev/hd*, it could even _save_ space in the > > >> kernel when converting to a clean SCSI based design. > > > > > >Please point me at that huge amount of code. Hint: there is none. > > > > I'm getting a grin: > > > > 15:46 takeshi:../drivers/ide > find . -type f -print0 | xargs -0 grep SG_IO > > (no results) > > > > Looks like it's already non-redundant :) > > everything in drivers/block/scsi_ioctl.c is duplicate code and I am sure I > would find more if I take some time....
axboe@nelson:[.]r/src/linux-2.6-block.git $ size block/scsi_ioctl.o text data bss dec hex filename 2844 256 0 3100 c1c block/scsi_ioctl.o
And it's not everything that's duplicated, basically only the ioctl parsing is. So either admit that there isn't a a lot of duplicated code, or "take some time" and point me at it. Otherwise refrain from making obviously false statements in the future.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |