[lkml]   [2006]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 04/04] Add dsa key type
    David Härdeman <> wrote:

    > Adds the dsa in-kernel key type.

    Please add a header file in include/keys/ to provide access to the key type
    definition and any special payload structures you use.

    > +static char *
    > +sign(const struct key_payload_dsa *skey,

    Please be consistent about sticking prefixes on the names of your
    functions. This ought to be called something like dsa_sign.

    > + printk("dsa: crypto_digest_setkey failed with error %i\n", i);

    Should involve KERN_ERR or something like.

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2006-01-24 12:11    [W:0.018 / U:56.932 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site