lkml.org 
[lkml]   [2006]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 04/04] Add dsa key type
    Date
    David Härdeman <david@2gen.com> wrote:

    > Adds the dsa in-kernel key type.

    Please add a header file in include/keys/ to provide access to the key type
    definition and any special payload structures you use.

    > +static char *
    > +sign(const struct key_payload_dsa *skey,

    Please be consistent about sticking prefixes on the names of your
    functions. This ought to be called something like dsa_sign.

    > + printk("dsa: crypto_digest_setkey failed with error %i\n", i);

    Should involve KERN_ERR or something like.

    David
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-01-24 12:11    [W:0.021 / U:0.024 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site