Messages in this thread |  | | | From | David Howells <> | | Subject | Re: [PATCH 04/04] Add dsa key type | | Date | Tue, 24 Jan 2006 11:08:45 +0000 |
| |
David Härdeman <david@2gen.com> wrote:
> Adds the dsa in-kernel key type.
Please add a header file in include/keys/ to provide access to the key type definition and any special payload structures you use.
> +static char * > +sign(const struct key_payload_dsa *skey,
Please be consistent about sticking prefixes on the names of your functions. This ought to be called something like dsa_sign.
> + printk("dsa: crypto_digest_setkey failed with error %i\n", i);
Should involve KERN_ERR or something like.
David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |