Messages in this thread | | | Date | Tue, 24 Jan 2006 00:58:06 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] tvec_bases too large for per-cpu data |
| |
"Jan Beulich" <JBeulich@novell.com> wrote: > > >- The `#ifdef CONFIG_NUMA' in init_timers_cpu() seems to be unnecessary - > > kmalloc_node() will use kmalloc() if !NUMA. > > That is correct, but I wanted the fallback if kmalloc_node() fails (from briefly looking at that code it didn't > seem like it would do such fallback itself). And calling kmalloc() twice if !NUMA seemed pointless.
I'm sorry, but how were we to know that? Telepathy?
GFP_KERNEL for these size objects is pretty much infallible anyway, so I wouldn't worry about it. Or allocate all needed storage a little later in boot with alloc_percpu().
> >- We prefer to do this: > > > > if (expr) { > > ... > > } else { > > ... > > } > > > > and not > > > > if (expr) { > > ... > > } > > else { > > ... > > } > > I can change that, too, but I don't see why this gets pointed out again and again when there really > is no consistency across the entire kernel... >
We fix these things up when working on incorrectly laid-out code, but we rarely bother raising a patch just to fix something like that. We'll get there eventually. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |