lkml.org 
[lkml]   [2006]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 02/04] Add dsa crypto ops
    On Tue, Jan 24, 2006 at 12:22:02PM +1100, Herbert Xu wrote:
    >David H?rdeman <david@2gen.com> wrote:
    >>
    >> +static int dsa_setkey(void *ctx, const u8 *key, unsigned int keylen, u32 *flags)
    >> +{
    >> + struct dsa_ctx *dctx = ctx;
    >> +
    >> + if (keylen != sizeof(struct key_payload_dsa *)) {
    >> + printk("Invalid key size in dsa_setkey\n");
    >> + return -EINVAL;
    >> + }
    >> +
    >> + dctx->key = (struct key_payload_dsa *)key;
    >> + return 0;
    >> +}
    >
    >This is bad. You're putting a pointer to an object with an unknown
    >lifetime into the tfm.
    >
    >Is there anything wrong with allocating the memory for it and storing
    >the key in the tfm like everyone else?

    No, not at all, it's a mistake and I'll change it...

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-01-24 07:52    [W:0.024 / U:3.880 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site