Messages in this thread | | | Date | Sun, 22 Jan 2006 12:59:02 -0800 | From | Tony Luck <> | Subject | Re: [PATCH] disable per cpu intr in /proc/stat |
| |
On 1/22/06, Andrew Morton <akpm@osdl.org> wrote: > Olaf Hering <olh@suse.de> wrote: > > Don't compute and display the per-irq sums on ia64 either, too much > > overhead for mostly useless figures. > > We'd need a big ack from the ia64 team for this, please.
This was found early in December. I proposed: http://marc.theaimsgroup.com/?l=linux-kernel&m=113398553428807&w=2 dropping it for all architectures, but got no response.
The problem is the horribly cache unfriendly scan of all percpu structures ... not too much of a problem for low cpu count, but really bad when the count gets high (just configured high is enough to cause the problem in a CONFIG_HOTPLUG_CPU kernel ... even if the cpu isn't present we still scan).
An alternative if someone really is using these values would be to compute the sums earlier in the function ... but that would require a memory allocation to save the per-irq sums.
Unless someone comes up soon with the name of an existing application that depends on these per-irq sums, consider this
Acked-by: Tony Luck <tony.luck@intel.com>
-Tony - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |