Messages in this thread | | | Date | Fri, 20 Jan 2006 10:28:17 +0100 | From | Mikael Pettersson <> | Subject | Re: [PATCH] x_tables: fix alignment on [at least] ppc32 |
| |
David S. Miller writes: > From: Harald Welte <laforge@netfilter.org> > Date: Fri, 20 Jan 2006 01:45:12 +0100 > > > [NETFILTER] x_tables: Fix XT_ALIGN() macro on [at least] ppc32 > > > > To keep backwards compatibility with old iptables userspace programs, > > the new XT_ALIGN macro always has to return the same value as IPT_ALIGN, > > IP6T_ALIGN or ARPT_ALIGN in previous kernels. > > > > However, in those kernels the macro was defined in dependency to the > > respective layer3 specifi data structures, which we can no longer do with > > x_tables. > > > > The fix is an ugly kludge, but it has been tested to solve the problem. Yet > > another reason to move away from the current {ip,ip6,arp,eb}tables like > > data structures. > > > > Signed-off-by: Harald Welte <laforge@netfilter.org> > > Harald, I'm going to modify this to just use u_int64_t as that > should be totally sufficient.
ACK. Both Harald's patch and DaveM's simplification of it (simply s/void */u_int64_t/g in XT_ALIGN()) fix the iptables problems on my ppc32 box.
/Mikael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |