![]() | |||||||||||
Messages in this thread |
On Fri, 2006-01-20 at 00:44 -0800, Andrew Morton wrote: > Oh crap. The damn thing wraps into column _1_ and gets tangled up with > ifdef statements, function definitions and other things which _should_ go > in column one. It does that only for people with editors which wrap stuff like that into column 1. Those people (which includes myself on some occasions) are _used_ to seeing stuff like that in column 1, so it's natural. And it's text which is of little importance; not something which has much relevance to the code flow. > It .looks. .like. .crap. to many other people, and saying random stupid > wrong things doesn't alter that very simple fact. No, it looks like crap for _some_ people. And making it look like crap for _everyone_, which is what your patch does, doesn't alter that fact either. It's a simple memcpy(dest, src, len), and the length is almost entirely superfluous -- we could almost get away with '*dest = *src' here. It lives on a single line and is messy any other way, and you want to muck about with it just because there are some poor sods out there for whom it would look _slightly_ better if you make it look like crap for the rest of us. I'm not advocating a blanket removal of the 80-character limit; important things should always be within 80 columns. But this is fluff; leave it where it is, please. -- dwmw2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||
| Last update: 2006-01-20 10:02 [from the cache] ©2003-2008 | |||||||||||