Messages in this thread | | | Date | Fri, 20 Jan 2006 15:10:30 -0800 | From | Pete Zaitcev <> | Subject | Re: [PATCH 2.4.32] usb-uhci.c failing "-" |
| |
On Fri, 20 Jan 2006 09:33:26 +0100 (CET), Guennadi Liakhovetski <gl@dsa-ac.de> wrote:
> Looks like a bug?
> --- a/drivers/usb/host/usb-uhci.c Fri Jan 20 09:27:50 2006 > +++ b/drivers/usb/host/usb-uhci.c Fri Jan 20 09:28:05 2006 > @@ -2505,7 +2505,7 @@ > ((urb_priv_t*)urb->hcpriv)->flags=0; > } > > - if ((urb->status != -ECONNABORTED) && (urb->status != ECONNRESET) && > + if ((urb->status != -ECONNABORTED) && (urb->status != -ECONNRESET) && > (urb->status != -ENOENT)) {
This is not what the author intended, obviously. But I am not quite sure what happens because of it. Seems like we unlink some things which are about to return anyway... and then return -104 instead of -84. This may be relatively harmless. At worst, the driver resubmits and gets its -84 that way.
I vote to apply this and see what happens. We are early in 2.4.33 cycle, so it should be safe.
-- Pete - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |