lkml.org 
[lkml]   [2006]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [patch 00/2] improve .text size on gcc 4.0 and newer compilers
    Date
    On Mon, 02 Jan 2006 19:49:06 +0100, Arjan van de Ven <arjan@infradead.org> wrote:

    >Maybe the right approach is to start rejecting in reviews new code that
    >uses inline inappropriately. (where "inappropriate" sort of is "more
    >than 3 lines of C unless there is some constant-optimizes-away trick")

    Well, I can own up to half a dozen inlines in a .c file, CodingStyle
    suggests to convert macros to static inline, so I did:

    /* adm9240 internally scales voltage measurements */
    static const u16 nom_mv[] = { 2500, 2700, 3300, 5000, 12000, 2700 };

    static inline unsigned int IN_FROM_REG(u8 reg, int n)
    {
    return SCALE(reg, nom_mv[n], 192);
    }

    static inline u8 IN_TO_REG(unsigned long val, int n)
    {
    return SENSORS_LIMIT(SCALE(val, 192, nom_mv[n]), 0, 255);
    }

    /* temperature range: -40..125, 127 disables temperature alarm */
    static inline s8 TEMP_TO_REG(long val)
    {
    return SENSORS_LIMIT(SCALE(val, 1, 1000), -40, 127);
    }

    Are these typical targets for non-inline?

    Thanks,
    Grant.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-01-02 22:54    [W:0.026 / U:29.644 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site