lkml.org 
[lkml]   [2006]   [Jan]   [19]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: - add-pselect-ppoll-system-call-implementation-tidy.patch removed from -mm tree
FromDavid Woodhouse <>
DateThu, 19 Jan 2006 16:21:59 +1100
On Wed, 2006-01-18 at 16:52 -0800, akpm@osdl.org wrote:
> -                       memcpy(&current->saved_sigmask, &sigsaved, sizeof(sigsaved));
> +                       memcpy(&current->saved_sigmask, &sigsaved,
> +                                       sizeof(sigsaved));

I still object to this.

You justified it on the basis that some people have editors which will
wrap the original version onto a second line and make it look ugly...
yet your 'fix' is to wrap it onto a second line and make it look ugly
for _all_ of us, not just for those using crap editors. I really don't
see the overall benefit.

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-01-19 05:24    [from the cache]
©2003-2008