lkml.org 
[lkml]   [2006]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] tpm_bios: needs more securityfs_ functions
    From: Randy Dunlap <rdunlap@xenotime.net>

    tpm_bios.c needs securityfs_xyz() functions.

    Does include/linux/security.h need stubs for these, or should
    char/tpm/Makefile just be modified to say:

    ifdef CONFIG_ACPI
    ifdef CONFIG_SECURITY
    obj-$(CONFIG_TCG_TPM) += tpm_bios.o
    endif
    endif

    drivers/char/tpm/tpm_bios.c:494: warning: implicit declaration of function 'securityfs_create_dir'
    drivers/char/tpm/tpm_bios.c:494: warning: assignment makes pointer from integer without a cast
    drivers/char/tpm/tpm_bios.c:499: warning: implicit declaration of function 'securityfs_create_file'
    drivers/char/tpm/tpm_bios.c:501: warning: assignment makes pointer from integer without a cast
    drivers/char/tpm/tpm_bios.c:508: warning: assignment makes pointer from integer without a cast
    drivers/char/tpm/tpm_bios.c:523: warning: implicit declaration of function 'securityfs_remove'
    *** Warning: "securityfs_create_file" [drivers/char/tpm/tpm_bios.ko] undefined!
    *** Warning: "securityfs_create_dir" [drivers/char/tpm/tpm_bios.ko] undefined!
    *** Warning: "securityfs_remove" [drivers/char/tpm/tpm_bios.ko] undefined!

    There are also some gcc and sparse warnings that could be fixed.
    (see http://www.xenotime.net/linux/doc/build-tpm.out)

    Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
    ---
    include/linux/security.h | 19 +++++++++++++++++++
    1 files changed, 19 insertions(+)

    --- linux-2616-rc1-secur.orig/include/linux/security.h
    +++ linux-2616-rc1-secur/include/linux/security.h
    @@ -2617,6 +2617,25 @@ static inline int security_netlink_recv
    return cap_netlink_recv (skb);
    }

    +static inline struct dentry *securityfs_create_dir(const char *name,
    + struct dentry *parent)
    +{
    + return NULL;
    +}
    +
    +static inline struct dentry *securityfs_create_file(const char *name,
    + mode_t mode,
    + struct dentry *parent,
    + void *data,
    + struct file_operations *fops)
    +{
    + return NULL;
    +}
    +
    +static inline void securityfs_remove(struct dentry *dentry)
    +{
    +}
    +
    #endif /* CONFIG_SECURITY */

    #ifdef CONFIG_SECURITY_NETWORK

    ---
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-01-20 05:30    [W:0.023 / U:29.952 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site