lkml.org 
[lkml]   [2006]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [uml-devel] [PATCH 8/8] uml: avoid "CONFIG_NR_CPUS undeclared" bogus error messages
    Date
    On Thursday 19 January 2006 05:21, Jeff Dike wrote:
    > On Thu, Jan 19, 2006 at 12:55:23AM +0100, Paolo 'Blaisorblade' Giarrusso
    wrote:
    > > -extern struct task_struct *idle_threads[NR_CPUS];
    > > -
    >
    > BTW, this isn't the only problem there. There are three declarations
    > towards the bottom with struct task_struct in them which have to be moved.

    I saw that after, but let's say a thing which I always forgot to say:

    we're often using void * in protos when we can't include a type declaration in
    the needed file.

    Gerd Knorr in his tty patch, instead, used forward declarations, like:

    struct task_struct;

    what about that?

    Those functions probably should be moved anyway because they're useless there,
    but I'm using this occasion to avoid forgetting this.
    --
    Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
    Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
    http://www.user-mode-linux.org/~blaisorblade


    ___________________________________
    Yahoo! Messenger with Voice: chiama da PC a telefono a tariffe esclusive
    http://it.messenger.yahoo.com

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-01-19 16:04    [W:0.022 / U:29.984 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site