lkml.org 
[lkml]   [2006]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [WATCHDOG] sa1100_wdt.c sparse cleanups
On Tue, 2006-01-17 at 20:04 +0100, Wim Van Sebroeck wrote:
> Hi Ian,
>
> > On Sat, 2005-11-05 at 10:10 +0000, Russell King wrote:
> >
> > > It's probably better to use a union with these, eg:
> >
> > The common idiom in the watchdog drivers seems to be to use separate
> > variables. I'll leave it up to Wim if he wants to change that.
> >
> > The following makes drivers/char/watchdog/sa1100_wdt.c sparse clean.
> >
> > Signed-off-by: Ian Campbell <icampbell@arcom.com>
>
> I seem to have missed this last e-mail (I was moving around that time...).
> This is indeed how it's been done in other drivers. I just uploaded this "patch"
> into my -mm test tree. Within a week or two I'll move it to the final watchdog tree.
>
> We should look to the struct watchdog part in more detail though.
> a union is an option, but probably not the only one :-)

Hi Wim,

Thanks for applying the patch.

BTW I've changed jobs since I sent it and I'm no longer working with ARM
hardware.

Ian.

--
Ian Campbell

Q: Why do the police always travel in threes?
A: One to do the reading, one to do the writing, and the other keeps
an eye on the two intellectuals.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2006-01-18 09:48    [W:0.173 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site