lkml.org 
[lkml]   [2006]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/8] uml: TT - SYSCALL_DEBUG - fix buglet introduced in cleanup
    Date

    Fixes a bug introduced in commit e32dacb9f481fd6decb41adb28e720c923d34f54 -
    index is initialized based on syscall before syscall is calculated.

    I'm bothering with this mainly because it gives a correct warning when the config
    option is enabled, even if the code is for a almost unused debugging option.

    Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
    ---

    arch/um/kernel/tt/syscall_kern.c | 8 ++++++--
    1 files changed, 6 insertions(+), 2 deletions(-)

    diff --git a/arch/um/kernel/tt/syscall_kern.c b/arch/um/kernel/tt/syscall_kern.c
    index 3d29c90..3fda9a0 100644
    --- a/arch/um/kernel/tt/syscall_kern.c
    +++ b/arch/um/kernel/tt/syscall_kern.c
    @@ -23,16 +23,20 @@ void syscall_handler_tt(int sig, struct
    int syscall;
    #ifdef CONFIG_SYSCALL_DEBUG
    int index;
    - index = record_syscall_start(syscall);
    #endif
    sc = UPT_SC(&regs->regs);
    SC_START_SYSCALL(sc);

    + syscall = UPT_SYSCALL_NR(&regs->regs);
    +
    +#ifdef CONFIG_SYSCALL_DEBUG
    + index = record_syscall_start(syscall);
    +#endif
    +
    syscall_trace(&regs->regs, 0);

    current->thread.nsyscalls++;
    nsyscalls++;
    - syscall = UPT_SYSCALL_NR(&regs->regs);

    if((syscall >= NR_syscalls) || (syscall < 0))
    result = -ENOSYS;
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-01-19 01:04    [W:0.033 / U:391.172 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site