Messages in this thread | | | From | Oliver Neukum <> | Subject | Re: [PATCH] hci_usb: implement suspend/resume | Date | Wed, 18 Jan 2006 16:34:08 +0100 |
| |
Am Mittwoch, 18. Januar 2006 15:13 schrieb Johannes Berg: > On Wed, 2006-01-18 at 14:25 +0100, Oliver Neukum wrote: > > > This patch is wrong. usb_kill_urb() will sleep. You must not use it under > > a spinlock. > > Whoops. Good catch. I'll have to analyse the logic with the lists being > used here (and probably add a temporary list). Will try to get a new > patch until tomorrow. > > [side note: how about adding might_sleep() to usb_kill_urb? Then I'd at > least have noticed this right away]
Good idea.
Regards Oliver - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |