lkml.org 
[lkml]   [2006]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] hci_usb: implement suspend/resume
From
Date
On Wed, 2006-01-18 at 14:25 +0100, Oliver Neukum wrote:

> This patch is wrong. usb_kill_urb() will sleep. You must not use it under
> a spinlock.

Whoops. Good catch. I'll have to analyse the logic with the lists being
used here (and probably add a temporary list). Will try to get a new
patch until tomorrow.

[side note: how about adding might_sleep() to usb_kill_urb? Then I'd at
least have noticed this right away]

johannes
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2006-01-18 15:16    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site