Messages in this thread | | | Date | Wed, 18 Jan 2006 11:26:41 +0900 | From | Kenji Kaneshige <> | Subject | Re: [Pcihpd-discuss] [patch 2/4] acpiphp: handle dock bridges |
| |
Hi,
> +static struct acpiphp_func * get_func(struct acpiphp_slot *slot, > + struct pci_dev *dev) > +{ > + struct list_head *l; > + struct acpiphp_func *func; > + struct pci_bus *bus = slot->bridge->pci_bus; > + > + list_for_each (l, &slot->funcs) { > + func = list_entry(l, struct acpiphp_func, sibling); > + if (pci_get_slot(bus, PCI_DEVFN(slot->device, > + func->function)) == dev) > + return func; > + }
This seems to leak reference counter of pci_dev. I think you must call pci_dev_put() also.
Thanks, Kenji Kaneshige - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |