Messages in this thread | | | From | "Sean Hefty" <> | Subject | RE: [PATCH 2/5] [RFC] Infiniband: connection abstraction | Date | Tue, 17 Jan 2006 15:51:23 -0800 |
| |
>> +static void cm_mask_compare_data(u8 *dst, u8 *src, u8 *mask) > >static void cm_mask_compare_data(u8 *dst, const u8 *src, u8 *mask) > >but I would rename it to cm_mask_copy since it doesn't really do a compare.
I'll change this. The function is masking the "data to use in the comparison", but I can see the confusion.
>> +static int cm_compare_data(struct ib_cm_private_data_compare *src_data, >> + struct ib_cm_private_data_compare *dst_data) > >static int cm_compare_data(const struct ib_cm_private_data_compare *src, > cosnt struct ib_cm_private_data_compare *dst) >Your data type names are getting too long ^^^^^^^^^^^^^^^^^^^^^^^^
I'll fix.
Thanks for the comments.
- Sean
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |