![]() | |||||||||||||
Messages in this thread Patch in this message |
On Mon, Jan 16, 2006 at 01:22:11PM +0100, Andi Kleen wrote: > > b) I can't find useful usage for the symbol size in print_symbol(). > > And symbolsize seems to be fixed when vmlinux or modules are compiled. > > So we can calculate it from vmlinux or modules. > > How about removing the field of symbolsize in print_symbol()? > > > > [<ffffffffa008ef6c>] kjournald+0x406 [jbd] > > It's a double check that the oops is matching the vmlinux you're looking > at. If we add system_utsname.version in oops so that we can compare with linux_banner[] in vmlinux, Will it be more precise and easier way to double check than checking symbolsize? --- 2.6-git/arch/i386/kernel/traps.c.orig 2006-01-17 12:45:41.000000000 +0900 +++ 2.6-git/arch/i386/kernel/traps.c 2006-01-17 12:49:35.000000000 +0900 @@ -239,9 +239,10 @@ void show_registers(struct pt_regs *regs } print_modules(); printk(KERN_EMERG "CPU: %d\nEIP: %04x:[<%08lx>] %s VLI\n" - "EFLAGS: %08lx (%s) \n", + "EFLAGS: %08lx (%s %s) \n", smp_processor_id(), 0xffff & regs->xcs, regs->eip, - print_tainted(), regs->eflags, system_utsname.release); + print_tainted(), regs->eflags, system_utsname.release, + system_utsname.version); print_symbol(KERN_EMERG "EIP is at %s\n", regs->eip); printk(KERN_EMERG "eax: %08lx ebx: %08lx ecx: %08lx edx: %08lx\n", regs->eax, regs->ebx, regs->ecx, regs->edx); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2006-01-17 08:07 [from the cache] ©2003-2008 | |||||||||||||