lkml.org 
[lkml]   [2006]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: Regression in Autofs, 2.6.15-git
    From
    Date
    On Sat, 2006-01-14 at 17:25 +0200, P. Christeas wrote:
    > On Saturday 14 January 2006 5:11 pm, P. Christeas wrote:
    > > Doesn't that mean that mnt==0x0004 ? Clearly wrong. I can also see from
    > > Christian's patch that mnt wasn't previously used, so it makes perfect
    > > sense for that commit to introduce the oops.
    > >
    > > I guess the problem lies in autofs4_revalidate (fs/autofs4/root.c:420), the
    > > nd->mnt value..
    > >
    > > I will add a silly validator (mnt>0xff) instead of (mnt) and see..
    > Confirmed: ((u32)mnt>0xff) discards the invalid 'mnt' value and the oops
    > disappears.
    > That is, the autofs4 code needs some debugging :( .

    Yes. It's me again.

    Could you try this patch please.

    --- linux-2.6.15/fs/autofs4/root.c.dumb-nameidata 2006-01-15 01:01:26.000000000 +0800
    +++ linux-2.6.15/fs/autofs4/root.c 2006-01-15 01:02:12.000000000 +0800
    @@ -193,6 +193,8 @@ static int autofs4_dir_open(struct inode
    if (!empty)
    d_invalidate(dentry);

    + nd.dentry = dentry;
    + nd.mnt = mnt;
    nd.flags = LOOKUP_DIRECTORY;
    status = (dentry->d_op->d_revalidate)(dentry, &nd);


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-01-14 18:09    [W:0.024 / U:0.832 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site