lkml.org 
[lkml]   [2006]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 2.6.15] ia64: use i386 dmi_scan.c
    Date
    On Friday 06 January 2006 15:39, Matt Domsch wrote:
    > diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig
    > ...
    > +config DMI
    > +       bool
    > +       default y

    Should we have a way to turn this off?

    > diff --git a/arch/ia64/kernel/Makefile b/arch/ia64/kernel/Makefile
    > ...
    > +dmi_scan-y                     += ../../i386/kernel/dmi_scan.o

    Ugh. I really hate this sort of sharing. Could dmi_scan.c go in
    drivers/firmware/ or something instead?

    > diff --git a/arch/ia64/kernel/setup.c b/arch/ia64/kernel/setup.c
    > ...
    > +static int __init run_dmi_scan(void)
    > +{
    > +       dmi_scan_machine();
    > +       return 0;
    > +}
    > +core_initcall(run_dmi_scan);

    Shouldn't this be wrapped in "#ifdef CONFIG_DMI"?

    Sorry this feedback is so late. I only looked at it because the
    DMI stuff crashes HP sx2000 (and probably sx1000) boxes, probably
    because of some memory attribute problem. So I'll have more
    feedback after I debug that ;-)
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-01-14 01:27    [W:0.043 / U:61.156 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site