Messages in this thread | | | From | Ingo Oeser <> | Subject | Re: [PATCH 01/17] BRIDGE: Fix faulty check in br_stp_recalculate_bridge_id() | Date | Fri, 13 Jan 2006 19:46:38 +0100 |
| |
Hi there,
On Friday 13 January 2006 03:37, Chris Wright wrote: > One of the conversions from memcmp to compare_ether_addr is incorrect. > We need to do relative comparison to determine min MAC address to > use in bridge id. This will cause the wrong bridge id to be chosen > which violates 802.1d Spanning Tree Protocol, and may create forwarding > loops.
Why not include a shorter version of this nice explanation above the list_for_each_entry() loop?
Like:
/* We try to find the min MAC address to use in this bridge id. */
This will prevent the next janitor from converting this again which avoids future regressions here.
What do you think?
Regards
Ingo Oeser
[unhandled content-type:application/pgp-signature] | |