Messages in this thread | | | Date | Wed, 11 Jan 2006 16:07:37 -0500 | From | Dmitry Torokhov <> | Subject | Re: [PATCH/RFC?] usb/input: Add support for fn key on Apple PowerBooks |
| |
On 12/26/05, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote: > On Sun, 2005-12-25 at 23:04 -0500, Dmitry Torokhov wrote: > > > As far as the hook itself - i have that feeling that it should not be > > done in kernel but via a keymap. > > While I understand your feeling, it's a bit annoying in this specific > case because previous models did this in hardware and all mac keymaps > already account for that. Knowing how nasty it has been to get mac > keymaps updated and in a good shape, and to get distros to properly get > them, it makes a lot of sense to have this small hook in the kernel that > makes the USB keyboard behave exactly like the older ADB couterparts. >
Ok, I am looking at the patch again, and I have a question - do we really need these 3 module parameters? If the goal is to be compatible with older keyboards then shouldn't we stick to one behavior?
-- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |