lkml.org 
[lkml]   [2006]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: [PATCH 1 of 3] Introduce __raw_memcpy_toio32
    From
    Date
    On Tue, 2006-01-10 at 17:07 +0000, Christoph Hellwig wrote:

    > Or add a CONFIG_GENERIC_MEMCPY_IO that's non-uservisible and just set
    > by all the architectures that don't provide their own version.

    Here's another i386-only review patch that does essentially that. It
    looks cleaner to me than my previous patch from this morning.
    (Copyrights and other arches omitted, for clarity.)

    What do you think?

    <b

    diff -r 48616306e7bd lib/Makefile
    --- a/lib/Makefile Tue Jan 10 10:41:42 2006 +0800
    +++ b/lib/Makefile Tue Jan 10 09:32:53 2006 -0800
    @@ -21,6 +21,7 @@
    lib-$(CONFIG_RWSEM_XCHGADD_ALGORITHM) += rwsem.o
    lib-$(CONFIG_SEMAPHORE_SLEEPERS) += semaphore-sleepers.o
    lib-$(CONFIG_GENERIC_FIND_NEXT_BIT) += find_next_bit.o
    +lib-$(CONFIG_GENERIC_RAW_MEMCPY_IO) += raw_memcpy_io.o
    obj-$(CONFIG_LOCK_KERNEL) += kernel_lock.o
    obj-$(CONFIG_DEBUG_PREEMPT) += smp_processor_id.o

    --- /dev/null Thu Jan 1 00:00:00 1970 +0000
    +++ b/include/asm-generic/raw_memcpy_io.h Tue Jan 10 09:32:53 2006 -0800
    @@ -0,0 +1,16 @@
    +#ifndef _ASM_GENERIC_RAW_MEMCPY_IO_H
    +#define _ASM_GENERIC_RAW_MEMCPY_IO_H
    +
    +/*
    + * __raw_memcpy_toio32 - copy data to MMIO space, in 32-bit units
    + *
    + * Order of access is not guaranteed, nor is a memory barrier performed
    + * afterwards. This is an arch-independent generic implementation.
    + *
    + * @to: destination, in MMIO space (must be 32-bit aligned)
    + * @from: source (must be 32-bit aligned)
    + * @count: number of 32-bit quantities to copy
    + */
    +void __raw_memcpy_toio32(void __iomem *to, const void *from, size_t count);
    +
    +#endif // _ASM_GENERIC_RAW_MEMCPY_IO_H
    diff -r 48616306e7bd lib/raw_memcpy_io.c
    --- /dev/null Thu Jan 1 00:00:00 1970 +0000
    +++ b/lib/raw_memcpy_io.c Tue Jan 10 09:32:53 2006 -0800
    @@ -0,0 +1,13 @@
    +#include <linux/types.h>
    +#include <asm/io.h>
    +#include <asm-generic/raw_memcpy_io.h>
    +
    +void __raw_memcpy_toio32(void __iomem *to, const void *from, size_t count)
    +{
    + u32 __iomem *dst = to;
    + const u32 *src = from;
    + size_t i;
    +
    + for (i = 0; i < count; i++)
    + __raw_writel(*src++, dst++);
    +}
    --- a/include/asm-i386/io.h Tue Jan 10 09:32:58 2006 -0800
    +++ b/include/asm-i386/io.h Tue Jan 10 09:35:16 2006 -0800
    @@ -203,6 +203,8 @@
    {
    __memcpy((void __force *) dst, src, count);
    }
    +
    +#include <asm-generic/raw_memcpy_io.h>

    /*
    * ISA space is 'always mapped' on a typical x86 system, no need to
    --- a/arch/i386/Kconfig Tue Jan 10 09:32:58 2006 -0800
    +++ b/arch/i386/Kconfig Tue Jan 10 09:35:16 2006 -0800
    @@ -34,6 +34,10 @@
    default y

    config GENERIC_IOMAP
    + bool
    + default y
    +
    +config GENERIC_RAW_MEMCPY_IO
    bool
    default y


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-01-10 18:52    [W:0.027 / U:0.088 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site