Messages in this thread | | | Date | Fri, 9 Sep 2005 18:51:08 -0700 (PDT) | From | Zwane Mwaikambo <> | Subject | Re: [patch 13/14] x86_64: Use common functions in cluster and physflat mode |
| |
On Fri, 10 Sep 2005, Andi Kleen wrote:
> On Fri, Sep 09, 2005 at 10:07:28AM -0700, Zwane Mwaikambo wrote: > > On Tue, 6 Sep 2005, Ashok Raj wrote: > > > > > On Tue, Sep 06, 2005 at 01:16:28AM +0200, Andi Kleen wrote: > > > > On Sat, Sep 03, 2005 at 02:33:30PM -0700, akpm@osdl.org wrote: > > > > > > > > > > From: Ashok Raj <ashok.raj@intel.com> > > > > > > > > > > Newly introduced physflat_* shares way too much with cluster with only a very > > > > > differences. So we introduce some common functions in that can be reused in > > > > > both cases. > > > > On a slightly different topic, how come we're using physflat for hotplug > > cpu? > > The original idea was to always use physflat mode for hotplug because > that does all the sequencing stuff and avoids the shortcut races. > But then Ashok decided it was better to add more ifdefs to flat mode > instead and I gave up protesting at some point.
Ok so you wanted to segragate them, i can understand that, but didn't we have a version which worked around the races by doing the same thing, hotplug or not? Is this the one where you weren't pleased with the supposed execution penalty?
Thanks, Zwane
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |