lkml.org 
[lkml]   [2005]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] bogus cast in bio.c
    On Fri, Sep 09, 2005 at 06:18:14PM +0200, Andreas Schwab wrote:
    > viro@ZenIV.linux.org.uk writes:
    >
    > > <qualifier> void * is not the same as void <qualifier> *...
    >
    > IMHO it should.

    ... and indeed it should. My apologies - that's a combination of
    sparse bug and me being very low on coffee...

    FWIW, looks like we are losing address_space in the first form: with current
    sparse we get
    fs/bio.c:686:15: warning: incorrect type in assignment (different address spaces)
    fs/bio.c:686:15: expected void [noderef] *iov_base<asn:1>
    fs/bio.c:686:15: got void [noderef] *<noident>
    from the first form (cast to __user void *). Lovely...

    OK, I think I know what's going on there, will fix.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-09-09 18:39    [W:0.029 / U:297.640 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site