Messages in this thread Patch in this message | | | Date | Wed, 07 Sep 2005 18:28:44 -0700 | From | Chris Wright <> | Subject | [PATCH 2/9] [PATCH] aacraid: 2.6.13 aacraid bad BUG_ON fix |
| |
-stable review patch. If anyone has any objections, please let us know. ------------------
This was noticed by Doug Bazamic and the fix found by Mark Salyzyn at Adaptec.
There was an error in the BUG_ON() statement that validated the calculated fib size which can cause the driver to panic.
Signed-off-by: Mark Haverkamp <markh@osdl.org> Acked-by: James Bottomley <James.Bottomley@SteelEye.com> Signed-off-by: Chris Wright <chrisw@osdl.org> --- drivers/scsi/aacraid/aachba.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.13.y/drivers/scsi/aacraid/aachba.c =================================================================== --- linux-2.6.13.y.orig/drivers/scsi/aacraid/aachba.c +++ linux-2.6.13.y/drivers/scsi/aacraid/aachba.c @@ -968,7 +968,7 @@ static int aac_read(struct scsi_cmnd * s fibsize = sizeof(struct aac_read64) + ((le32_to_cpu(readcmd->sg.count) - 1) * sizeof (struct sgentry64)); - BUG_ON (fibsize > (sizeof(struct hw_fib) - + BUG_ON (fibsize > (dev->max_fib_size - sizeof(struct aac_fibhdr))); /* * Now send the Fib to the adapter -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |