lkml.org 
[lkml]   [2005]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 2.6.13 2/2] 3c59x: add option for using memory-mapped PCI I/O resources
Christoph Hellwig <hch@infradead.org> wrote:
>
> On Tue, Sep 06, 2005 at 04:44:00PM -0400, John W. Linville wrote:
> > Add module option to enable 3c59x driver to use memory-mapped PCI I/O
> > resources. This may improve performance for those devices so equipped.
> >
> > Add "use_mmio=1" to the 3c59x module options in order to enable this
> > functionality.
>
> I'm not sure a module option makes sense for this setting, except maybe
> as a debugging aid. You should rather have a flag in the PCI IDs private
> data that can be used to enable mmio for those cards that support it.

I guess it's OK for the initial testing. Plus we should make the new
feature default to "on" during initial public testing. I'll make that
change.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-09-06 23:08    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site