Messages in this thread | | | Date | Fri, 30 Sep 2005 18:56:32 -0400 | From | Dave Jones <> | Subject | Re: [Patch] x86, x86_64: fix cpu model for family 0x6 |
| |
On Sat, Oct 01, 2005 at 12:37:39AM +0200, Petr Vandrovec wrote: > Siddha, Suresh B wrote: > >On Sat, Oct 01, 2005 at 12:02:16AM +0200, Andi Kleen wrote: > > > >>I applied an earlier mix of your original one and Petr's suggestions. > >>Hope it's ok. > > > > > >Andi I prefer to follow the SDM guidelines. Who knows if future families > >comeup with a different rule or use/initialize these extended model/family > >bits differently. I am just being paranoid. > > And which chance is bigger - that such hypothetical processor will use > extended model, and your code will get incorrect answer everywhere, or > that such hypothetical processor will not use extended model, and your > code will be right? > > >>+ if (c->x86 >= 0xf) > > > > > >And also you have a typo. It should be 0x6. > > It is intentional. Maybe it could do BUG_ON(c->x86 < 0xf).
<complete speculation> Pentium M is family 6, so maybe this is an indication we'll see em64t capable P-M's soon ? :)
Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |