Messages in this thread | | | From | Kyle Moffett <> | Subject | Re: I request inclusion of SAS Transport Layer and AIC-94xx into the kernel | Date | Fri, 30 Sep 2005 14:50:27 -0400 |
| |
On Sep 30, 2005, at 14:34:42, Luben Tuikov wrote: > This is how we have the SPI-centric EH methods in the scsi host > template right now: > int (* eh_abort_handler)(struct scsi_cmnd *); > int (* eh_device_reset_handler)(struct scsi_cmnd *); > int (* eh_bus_reset_handler)(struct scsi_cmnd *); > int (* eh_host_reset_handler)(struct scsi_cmnd *);
So submit patches to fix it! You clearly understand what is wrong, so why not help change it?
> But we should _not_ break legacy drivers and backward support,
WRONG. This is not the way Linux works. We break internal APIs all the time. If you need to change one _thats_OK_. Userspace ABI is mostly another matter, but that's different from the internal data structures and functions.
> The way we do this is we slowly, without disruption to older > drivers introduce, in parallel, emerge a new, simpler, slimmer, > faster SCSI Core, whereby we accommodate new infrastructures, yet, > have 100% backward compatibility, via the current older SCSI Core. > After all, both would be a bunch of functions in a bunch of files.
Except this introduces bloat and multiplies maintainer load. Fix the existing one. If it breaks other in-core drivers, fix those to match. If it breaks out-of-tree drivers, too bad! They should get their code upstream and then they wouldn't need to worry.
> If X works with Y, do not disrupt it. Fix it if it's broken. > Introduce innovation, functionality, better design, but not at the > expense of breaking legacy.
This is not the way Linux works. It may be the way Adaptec works, but that's not relevant here.
> Section 4: Politics > -------------------
s/Politics.*//g; I hate politics. Keep it off this list.
Cheers, Kyle Moffett
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |