lkml.org 
[lkml]   [2005]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [linux-usb-devel] Re: [Security] [vendor-sec] [BUG/PATCH/RFC] Oops while completing async USB via usbdevio


    On Tue, 27 Sep 2005, Sergey Vlasov wrote:
    >
    > The initial patch added get_task_struct()/put_task_struct() calls to
    > fix this - are they forbidden too?

    They are sure as hell not something that a _driver_ is supposed to use.

    > It at least has sigio_perm(), which prevents exploiting it to send
    > signals to tasks you don't have access to.

    And the point is, you can do that _too_.

    Do it right. Don't cache pointers to threads. Use the pid.

    Your security arguments are _pointless_. As proven by the fact that SIGIO
    happily uses a pid, and gets it right. Try to use _that_ infrastructure
    instead, since that's what it's _meant_ for.

    The fact is, having drivers much around with thread locking is not
    acceptable. Drivers _will_ get it wrong, and even if they didn't, it's
    kernel internal data structures that drivers have no business in touching.

    Linus
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-11-18 23:46    [W:0.022 / U:60.716 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site