Messages in this thread | | | Date | Tue, 27 Sep 2005 07:54:42 -0700 | From | Greg KH <> | Subject | Re: [spi-devel-general] Re: SPI |
| |
On Tue, Sep 27, 2005 at 06:49:57PM +0400, dmitry pervushin wrote: > On Tue, 2005-09-27 at 07:35 -0700, Greg KH wrote: > > Please read up on how the lifetime rules work for devices, and what > > needs to happen in the release function (hint, take a look at other > > busses, like USB and PCI for examples of what needs to be done.) > As far as I can see, pci_release_device deletes the pci_dev using kfree.
Yes.
> But here we have statically allocated spi_device structures -- > spi_device_add does not allocate spi_device, but uses caller-allocated > one.
Not good, reference counted structures almost always should be dynamically created. Please change this to also be true for SPI, otherwise you will have a lot of nasty issues with devices that can be removed at any point in time.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |