lkml.org 
[lkml]   [2005]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: New inventions in rounding up in catc.c?
Date
On Saturday 24 September 2005 21:46, Grant Coady wrote:
> On Sat, 24 Sep 2005 13:43:42 +0300, Denis Vlasenko <vda@ilport.com.ua> wrote:
> > /* F5U011 only does one packet per RX */
> > if (catc->is_f5u011)
> > break;
> >- pkt_start += (((pkt_len + 1) >> 6) + 1) << 6;
> >+ pkt_start += ((pkt_len + 2) + 63) & ~63;
>
> pkt_start += ((pkt_len + 1) + 64) & ~63;
>
> Seems more clear to me.

Why?

((pkt_len + 2) + 63) & ~63 is "add 2 and round up to next 64".
((pkt_len + 1) + 64) & ~63 is "???!"

It's strange code anyway, I hope maintainer can clarify what's going on.
(I suspect it was intended to be pkt_len - 1, not +, in the first place)
--
vda
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-09-25 12:50    [from the cache]
©2003-2011 Jasper Spaans