![]() | |||||||||||||
Messages in this thread |
On Fri, 2005-09-23 at 00:17 -0700, David S. Miller wrote: > I'm still against expanding these networking datastructures with > bigrefs just for this stuff. Some people have per-cpu and per-node on > the brain, and it's starting to bloat things up a little bit too much. I think for net devices it actually makes sense; most of the time we are not trying to remove them, so the refcounting is simply overhead. We also don't alloc and free them very often. The size issue is not really an issue since we only map for each CPU, and even better: if a bigref allocation can't get per-cpu data it just degrades beautifully into a test and an atomic. Now, that said, I wanted (and wrote, way back when) a far simpler allocator which only worked for GFP_KERNEL and used the same __per_cpu_offset[] to fixup dynamic per-cpu ptrs as static ones. Maybe not as "complete" as this one, but maybe less offensive. Rusty. -- A bad analogy is like a leaky screwdriver -- Richard Braakman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-09-23 08:14 [W:3.079 / U:0.610 seconds] ©2003-2008 Jasper Spaans | |||||||||||||