Messages in this thread | | | Date | Thu, 22 Sep 2005 14:48:03 +0200 | From | Harald Welte <> | Subject | Re: [PATCH 2/3] netfilter : 3 patches to boost ip_tables performance |
| |
On Wed, Sep 21, 2005 at 11:32:24PM +0200, Eric Dumazet wrote: > Patch 2/3 (please apply after Patch 1/3) > > 2) Loop unrolling
First of all, thanks for your performance analysis and patches. I'm very inclined of merging them.
> It seems that with current compilers and CFLAGS, the code from > ip_packet_match() is very bad, using lot of mispredicted conditional branches I made some patches > and generated code on i386 and x86_64 > is much better.
This only describes your "compare_if_lstrings()" changes, and I'm happy to merge them.
However, you also removed the use of the FWINV macro and replaced it by explicit code (including the bool1/bool2 variables, which are not really named intuitively). Why was this neccessary?
-- - Harald Welte <laforge@netfilter.org> http://netfilter.org/ ============================================================================ "Fragmentation is like classful addressing -- an interesting early architectural error that shows how much experimentation was going on while IP was being designed." -- Paul Vixie [unhandled content-type:application/pgp-signature] | |