Messages in this thread | | | Date | Wed, 21 Sep 2005 22:38:26 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH] bond_main.c: fix device deregistration in init exception path |
| |
Andrew Morton wrote: > diff -puN drivers/net/bonding/bond_main.c~bond_mainc-fix-device-deregistration-in-init-exception drivers/net/bonding/bond_main.c > --- devel/drivers/net/bonding/bond_main.c~bond_mainc-fix-device-deregistration-in-init-exception 2005-09-17 23:18:38.000000000 -0700 > +++ devel-akpm/drivers/net/bonding/bond_main.c 2005-09-17 23:31:02.000000000 -0700 > @@ -5039,6 +5039,14 @@ static int __init bonding_init(void) > return 0; > > out_err: > + /* > + * rtnl_unlock() will run netdev_run_todo(), putting the > + * thus-far-registered bonding devices into a state which > + * unregigister_netdevice() will accept > + */ > + rtnl_unlock(); > + rtnl_lock(); > +
Don't we want a schedule() or schedule_timeout(1) in between?
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |