Messages in this thread |  | | | Date | Wed, 21 Sep 2005 12:48:05 -0700 (PDT) | | From | Christoph Lameter <> | | Subject | Re: [PATCH 2.6.14-rc2] fix incorrect mm->hiwater_vm and mm->hiwater_rss |
| |
On Wed, 21 Sep 2005, Hugh Dickins wrote:
> > But I think you're right that hiwater_vm is best updated where total_vm > is: I'm not sure if it covers all cases completely (I think there's one > or two places which don't bother to call __vm_stat_account because they > believe it won't change anything), but in principle it would make lots of > sense to do it in the __vm_stat_account which typically follows adjusting > total_vm, as you did, and if possible nowhere else; rather than adding > your inline above. > > Would you be satisfied with that, Christoph?
Looks like this is staying off the critical code paths. So ok.
> I'm also rearranging the rss,anon_rss accounting. Maybe come back > to the hiwaters later on?
I'd be very interested to see the rearrangement. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |