Messages in this thread | | | Date | Tue, 20 Sep 2005 17:58:44 -0700 | From | "Siddha, Suresh B" <> | Subject | Re: [patch] intel_cacheinfo: remove MAX_CACHE_LEAVES limit |
| |
On Tue, Sep 20, 2005 at 04:06:04PM -0700, Andrew Morton wrote: > "Siddha, Suresh B" <suresh.b.siddha@intel.com> wrote: > > > > Remove the MAX_CACHE_LEAVES limit from the routine which calculates the > > number of cache levels using cpuid(4) > > Why? Why was the code there originally, and why is it required that it be > removed, and why is it safe to remove it? > > (IOW: your description of this patch is inadequate: it describes what was > done, but not why it was done).
oops! Initial internal version of Venki's cpuid(4) deterministic cache parameter identification patch used static arrays of size MAX_CACHE_LEAVES. Final patch which made to the base used dynamic array allocation, with this MAX_CACHE_LEAVES limit hunk still in place.
cpuid(4) already has a mechanism to find out the number of cache levels implemented and there is no need for this hardcoded MAX_CACHE_LEAVES limit.
thanks, suresh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |